[AMD] Refactor kWidth Assignment into Separate Logic #8552
+148
−52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored kWidth assignment into separate logic from the MFMA intrinsic logic.
For now, the logic has been refactored into separate rewrite rules. However, the logic could feasibly be refactored into a separate pass as well; I tried this initially but ran into some issues.
Two things:
isChainDotif possible, but I haven't figured out a way to detect the chain dot scenario; if someone has a better way centered around theConvertLayoutoperation, please let me know.