Skip to content

Conversation

@christopherpriebe
Copy link
Contributor

@christopherpriebe christopherpriebe commented Oct 27, 2025

Refactored kWidth assignment into separate logic from the MFMA intrinsic logic.

For now, the logic has been refactored into separate rewrite rules. However, the logic could feasibly be refactored into a separate pass as well; I tried this initially but ran into some issues.

Two things:

  • I don't want to use the function isChainDot if possible, but I haven't figured out a way to detect the chain dot scenario; if someone has a better way centered around the ConvertLayout operation, please let me know.
  • I tried to refactor out the scaled dot kWidth logic as well, but it isn't as simple as the normal dot kWidth logic. The logic is 1) centered around properties directly associated with the scaled dot operation and 2) needs to be propagated it seems through other IR constructs. When I tried doing this same logic separately, it caused a lot of failures.

@christopherpriebe christopherpriebe changed the title Refactor kWidth Assignment into Separate Logic [AMD] Refactor kWidth Assignment into Separate Logic Oct 27, 2025
@christopherpriebe christopherpriebe marked this pull request as ready for review October 29, 2025 15:25
@zhanglx13 zhanglx13 marked this pull request as draft November 5, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant