Skip to content

Conversation

@pchen7e2
Copy link
Contributor

#6381 updated some building and doc but didn't fix the command to find the proper compile_commands.json. python/build would contain the old one if user has previously built the project in ./python, which would not work now, since we now build the project at dir .

New contributor declaration

  • I am not making a trivial change, such as fixing a typo in a comment.

  • I have written a PR description following these
    rules.

  • I have run pre-commit run --from-ref origin/main --to-ref HEAD.

  • Select one of the following.

    • I have added tests.
      • /test for lit tests
      • /unittest for C++ tests
      • /python/test for end-to-end tests
    • This PR does not need a test because it's a trivial doc fix.
  • Select one of the following.

    • I have not added any lit tests.
    • The lit tests I have added follow these best practices,
      including the "tests should be minimal" section. (Usually running Python code
      and using the instructions it generates is not minimal.)

triton-lang#6381 updated some building and doc but didn't fix the command to find the proper `compile_commands.json`. `python/build` would contain the old one if user has previously built the project in `./python`, which would not work now.
@pchen7e2 pchen7e2 requested a review from ptillet as a code owner April 29, 2025 23:07
@Jokeren Jokeren merged commit b38d1b1 into triton-lang:main Apr 30, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants