[python][typing] Specify mypy_path in pyproject.toml #6596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you! That said, wouldn't configuring it in |
danzimm
changed the title
Contributor
Author
|
@mgorny yeah, for sure, good catch. Just updated the PR to do that |
FindHao
pushed a commit
to FindHao/triton
that referenced
this pull request
Apr 30, 2025
This PR adds basic mypy type checking to the codebase. Previously, type checking worked out of the box (e.g., via pylsp-mypy in Neovim with an editable install), but after [triton-lang#6381](triton-lang#6381), mypy started reporting: Cannot find implementation or library stub for module named 'triton'. This is likely due to a known issue with type checkers and editable installs. As a workaround, this PR introduces a mypy.ini with a [`mypy_path`](https://mypy.readthedocs.io/en/stable/config_file.html#confval-mypy_path) to restore correct module resolution. This is a small step toward making the Python codebase fully type-checkable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds basic mypy type checking to the codebase.
Previously, type checking worked out of the box (e.g., via pylsp-mypy in Neovim with an editable install), but after #6381, mypy started reporting:
Cannot find implementation or library stub for module named 'triton'.
This is likely due to a known issue with type checkers and editable installs. As a workaround, this PR introduces a mypy.ini with a
mypy_pathto restore correct module resolution.This is a small step toward making the Python codebase fully type-checkable.