Skip to content

Support NVIDIA 50 series GPU #6120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Support NVIDIA 50 series GPU #6120

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/Dialect/TritonGPU/Transforms/AccelerateMatmul.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,14 @@ namespace {
static int getMMAVersionSafe(int computeCapability, DotOp op) {
// List supported mma version in order of preference.
SmallVector<int> versionsSupported;
op.emitRemark() << "Your computeCapability is " << computeCapability;
Copy link
Collaborator

@ThomasRaoux ThomasRaoux Mar 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this to avoid noise.

if (computeCapability < 75) {
versionsSupported = {1};
} else if (computeCapability < 90) {
versionsSupported = {2};
} else if (computeCapability < 100) {
versionsSupported = {3, 2};
} else if (computeCapability < 110) {
} else if (computeCapability < 130) {
versionsSupported = {5, 2};
Copy link
Collaborator

@masahi masahi Mar 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consumer cards only support Ampere-style mma. So only the version 2 is supported.

Copy link
Contributor

@oteroantoniogom oteroantoniogom Mar 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you still get an error go to AccelerateMatmul.cpp and just delete the 5 and leave it like:

  } else if (computeCapability < 130) {
    versionsSupported = {2};

As @masahi pointed, consumer RTX 5090 only supports version 2.

Copy link
Contributor

@Jokeren Jokeren Mar 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleting the 110 branch is wrong. Need to add a 130 branch with only version {2}.

} else {
assert(false && "computeCapability not supported");
Expand Down