Skip to content

[CI] Run examples in CI#3361

Closed
oraluben wants to merge 6 commits intotriton-lang:mainfrom
oraluben:batch
Closed

[CI] Run examples in CI#3361
oraluben wants to merge 6 commits intotriton-lang:mainfrom
oraluben:batch

Conversation

@oraluben
Copy link
Copy Markdown
Contributor

@oraluben oraluben commented Mar 13, 2024

Run examples in CI (H100 only, as it's ~2min faster than A100, and additional example takes 30s and doesn't depend on the device).

@oraluben oraluben requested a review from ptillet as a code owner March 13, 2024 03:34
@jlebar
Copy link
Copy Markdown
Contributor

jlebar commented Mar 13, 2024

Let's see how long it takes to run the examples in CI, I'm not sure it will be fast.

@oraluben
Copy link
Copy Markdown
Contributor Author

Let's see how long it takes to run the examples in CI, I'm not sure it will be fast.

It looks simple and on my dev env it takes ~10s. Should be similar in CI.

@jlebar
Copy link
Copy Markdown
Contributor

jlebar commented Mar 13, 2024

It looks like running the examples takes 30 seconds, 9m57s here on A100 vs 9m25s in https://github.com/openai/triton/actions/runs/8253494425/job/22575490486?pr=3353. (The H100 build is failing for reasons unrelated to this PR, the VM is unhappy.)

I'm not sure running the examples is worth increasing CI time by 5% for all PRs. We could make it part of a nightly run, although in truth people don't look at those very carefully.

As a compromise I guess we could run the examples only on H100, since the H100 builds are a few minutes faster than A100.

@jlebar jlebar requested a review from ThomasRaoux March 13, 2024 16:04
@jlebar
Copy link
Copy Markdown
Contributor

jlebar commented Mar 13, 2024

Thanks, this LGTM but I'll let Thomas approve and decide on the question of merging those two op definitions. I'm grateful that you're cleaning things up based on the bugs you've found and fixed, thank you.

@oraluben oraluben changed the title Trivial updates [CI] Run examples in CI Mar 14, 2024
oraluben and others added 2 commits March 14, 2024 10:36
Co-authored-by: Justin Lebar <justin.lebar@gmail.com>
@ptillet
Copy link
Copy Markdown
Collaborator

ptillet commented Mar 14, 2024

I don't think it is the right place to run examples. In fact, I don't even think the examples directory should exist anymore. All educational material should live in tutorials, which should be built nightly.

@ptillet ptillet closed this Mar 14, 2024
@oraluben
Copy link
Copy Markdown
Contributor Author

All educational material should live in tutorials, which should be built nightly.

Fair enough, this indeed sounds better.

Thanks for reviewing this! @jlebar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants