Skip to content

Bump electron-builder #18919

@Lemonexe

Description

@Lemonexe

Bump electron-builder from 26.0.3 to latest.
(#16880 marks the last time electron-builder was bumped successfully).

Multiple issues there:

  • 26.0.4 broke yarn workspaces, but that was fixed in 26.0.12
  • 26.0.12 (nominally @latest) had signing issues and was reverted
    • cause unknown yet, to be investigated?
  • 26.0.13 includes #9007: ARM dmg builds signed adhoc by default
    • this causes a different crash in CI
  • at 26.0.15, a workaround was attempted in #18906
    • build succeeds but the x64 app crashes immediately
    • also icon is missing??
  • at 26.1.0 yarn is broken
  • at 26.3.0 yarn works but emits harmless error in console
    • fixed in 26.3.1
  • at 26.3 there is a bug where app.asar.unpacked contains hundreds of extra MB, TODO solve this

👉 The goal is to have all build targets working:

  • win prod x64
  • macOS prod arm
  • linux prod x64
  • macOS dev x64 dmg build
    • optionally switch to macOS dev arm build, I don't know how that works with the "adhoc signing"?

Note: This issue waits for a macOS-native developer.. nvm I'm gonna borrow a macBook and finally solve it 😆
I confirmed at 26.0.15 that Linux and Windows builds are impeccable.

Metadata

Metadata

Assignees

Labels

dependenciesPull requests that update a dependency file

Type

Projects

Status

✅ Approved

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions