Skip to content

Added countries field to language type, improved filtering across countries, languages and continents#74

Open
btroop wants to merge 1 commit intotrevorblades:mainfrom
btroop:languages-with-countries
Open

Added countries field to language type, improved filtering across countries, languages and continents#74
btroop wants to merge 1 commit intotrevorblades:mainfrom
btroop:languages-with-countries

Conversation

@btroop
Copy link
Contributor

@btroop btroop commented Aug 13, 2025

  1. Expanded graph capabilities by pulling in list of countries associated with a language so dual direction graph traversal is possible. Now you can query and language and see what countries speak it.
  2. Expanded filtering capabilities for countries, languages and continents. now can filter a country by languages, filter languages by country, and filter continents by either language or country or both

Utility functions were added to support each of the new features

…ries, languages and continents (includes supporting utilities)
@vercel
Copy link

vercel bot commented Aug 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Project Deployment Preview Comments Updated (UTC)
countries Ready Preview Comment Aug 13, 2025 6:44pm

@trevorblades
Copy link
Owner

This is really cool! Thanks for putting this PR together.

IMO, the best path to move this ahead would be splitting this PR into two:

  1. add the countries field to the Language type
  2. all the other filtering changes

The first PR (adding the countries field) could be merged and deployed right away. The filtering part is gonna have to take some more time to review. I think that adding countries to the Language type is such a good improvement that it shouldn't have to wait for the rest of the code to get reviewed before it gets in.

How's this sound to you?

@btroop
Copy link
Contributor Author

btroop commented Aug 13, 2025

This is really cool! Thanks for putting this PR together.

IMO, the best path to move this ahead would be splitting this PR into two:

  1. add the countries field to the Language type
  2. all the other filtering changes

The first PR (adding the countries field) could be merged and deployed right away. The filtering part is gonna have to take some more time to review. I think that adding countries to the Language type is such a good improvement that it shouldn't have to wait for the rest of the code to get reviewed before it gets in.

How's this sound to you?

glad you like it. your suggestion sounds good to me; i've never contributed to an open source project before, so is splitting the PR into two something you'll manage, or do you want me to take a crack at it?

@trevorblades
Copy link
Owner

No problem! The way I'd do it is to open a new branch based off of main, and copy the countries field resolver code from this PR into there. Then open a new PR based on that branch.

I'll merge that change, and then we can rebase this branch so that it only includes the code related to filtering. At that point, the new countries field will be merged and deployed, and I can spend some time reviewing the remaining changes in here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants