Skip to content

fix: properly handle supertypes#34

Merged
clason merged 1 commit intomasterfrom
supertype
May 6, 2024
Merged

fix: properly handle supertypes#34
clason merged 1 commit intomasterfrom
supertype

Conversation

@amaanq
Copy link
Copy Markdown
Member

@amaanq amaanq commented May 6, 2024

No description provided.

@clason
Copy link
Copy Markdown
Contributor

clason commented May 6, 2024

Did you test this with the query formatter and linter?

@amaanq
Copy link
Copy Markdown
Member Author

amaanq commented May 6, 2024

nope, not sure how

@clason
Copy link
Copy Markdown
Contributor

clason commented May 6, 2024

This inflates state count quite a bit, though...

nope, not sure how

Manually build the parser, put it in .local/share/nvim/site/parser, then open the Haskell query with Neovim.

@clason
Copy link
Copy Markdown
Contributor

clason commented May 6, 2024

Seems to work as well. I do worry about state count, though. Maybe try moving the seq into a separate hidden rule?

@clason
Copy link
Copy Markdown
Contributor

clason commented May 6, 2024

Also, this will break queries, which expect name: (identifier)?

@amaanq
Copy link
Copy Markdown
Member Author

amaanq commented May 6, 2024

Seems to work as well. I do worry about state count, though. Maybe try moving the seq into a separate hidden rule?

This increases it by 30

Also, this will break queries, which expect name: (identifier)?

No, unless it's anchored, since the name field is present in both places

@lucario387
Copy link
Copy Markdown

This should not break the formatter, at least from what I can see. Running format-queries runtime/queries in the haskell PR results in 0diff with the result of latest nvim-treesitter

@clason clason merged commit 87b1a3d into master May 6, 2024
@clason clason deleted the supertype branch May 6, 2024 15:47
@clason
Copy link
Copy Markdown
Contributor

clason commented May 6, 2024

Will make a release with this later today.

@clason
Copy link
Copy Markdown
Contributor

clason commented May 7, 2024

@amaanq Do we want to add queries for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants