fix: removed unnecessary char casting#200
Merged
ObserverOfTime merged 1 commit intotree-sitter-grammars:split_parserfrom Jun 7, 2025
Merged
fix: removed unnecessary char casting#200ObserverOfTime merged 1 commit intotree-sitter-grammars:split_parserfrom
ObserverOfTime merged 1 commit intotree-sitter-grammars:split_parserfrom
Conversation
Contributor
Author
|
Before: Screen.Recording.2025-06-07.at.02.52.35.movAfter: Screen.Recording.2025-06-07.at.02.55.59.movAlso docs state that lookahead returns int32_t so there really is no reason to cast it to char |
ObserverOfTime
merged commit 9dca2b6
into
tree-sitter-grammars:split_parser
2 of 5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scanner did some unnecessary casting of int32_t to char. That casting truncated every character to 8 bits (ascii), while it should be unicode. Because of that symbols like
Шwould be parsed as(and therefore would not parse as emphasis when it should.This simple commit fixes that.