Skip to content

Correct LogReader interface #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlCutter merged 1 commit into from
May 23, 2025
Merged

Correct LogReader interface #663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions internal/stream/follower.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,13 +48,6 @@ type Streamer interface {
// log should be used. If in doubt, use ReadCheckpoint instead.
IntegratedSize(ctx context.Context) (uint64, error)

// NextIndex returns the first as-yet unassigned index.
//
// In a quiescent log, this will be the same as the checkpoint size. In a log with entries actively
// being added, this number will be higher since it will take sequenced but not-yet-integrated/not-yet-published
// entries into account.
NextIndex(ctx context.Context) (uint64, error)

// StreamEntries returns an iterator over the range of requested entries [startEntryIdx, startEntryIdx+N).
//
// The iterator will yield either a Bundle struct or an error. If an error is returned the caller should
Expand Down
7 changes: 7 additions & 0 deletions lifecycle.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,13 @@ type LogReader interface {
// The expected usage and corresponding behaviours are similar to ReadTile.
ReadEntryBundle(ctx context.Context, index uint64, p uint8) ([]byte, error)

// NextIndex returns the first as-yet unassigned index.
//
// In a quiescent log, this will be the same as the checkpoint size. In a log with entries actively
// being added, this number will be higher since it will take sequenced but not-yet-integrated/not-yet-published
// entries into account.
NextIndex(ctx context.Context) (uint64, error)

stream.Streamer
}

Expand Down
Loading