Simpler stream #656
Merged
Simpler stream #656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlCutter
force-pushed
the
simpler_stream
branch
10 times, most recently
from
ddad324 to
7879f23
Compare
AlCutter
force-pushed
the
simpler_stream
branch
3 times, most recently
from
1f6b4cf to
1889b19
Compare
mhutchinson
reviewed
May 21, 2025
mhutchinson
approved these changes
May 21, 2025
stream.StreamAdaptor --> stream.EntryBundles stream.NewEntryReader --> stream.Entries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the
streampackage a little simpler to use/reason about:StreamAdaptornow returns a Go iterator, and iterates only over the explicitly request range of entries (previously it would hang forever and return new entries if/when the tree grew)EntryReaderis replaced with an iterator wrapper forStreamAdaptor