Skip to content

bubble up abort other spanner errors to enable retries #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlCutter merged 1 commit into from
May 19, 2025
Merged

bubble up abort other spanner errors to enable retries #651

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions storage/gcp/gcp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -908,7 +908,7 @@ func (s *spannerCoordinator) publishTree(ctx context.Context, minAge time.Durati
if _, err := s.dbPool.ReadWriteTransaction(ctx, func(ctx context.Context, txn *spanner.ReadWriteTransaction) error {
pRow, err := txn.ReadRowWithOptions(ctx, "PubCoord", spanner.Key{0}, []string{"publishedAt"}, &spanner.ReadOptions{LockHint: spannerpb.ReadRequest_LOCK_HINT_EXCLUSIVE})
if err != nil {
return fmt.Errorf("failed to read PubCoord: %v", err)
return fmt.Errorf("failed to read PubCoord: %w", err)
}
var pubAt time.Time
if err := pRow.Column(0, &pubAt); err != nil {
Expand All @@ -918,7 +918,7 @@ func (s *spannerCoordinator) publishTree(ctx context.Context, minAge time.Durati
// Can't just use currentTree() here as the spanner emulator doesn't do nested transactions, so do it manually:
row, err := txn.ReadRow(ctx, "IntCoord", spanner.Key{0}, []string{"seq", "rootHash"})
if err != nil {
return fmt.Errorf("failed to read IntCoord: %v", err)
return fmt.Errorf("failed to read IntCoord: %w", err)
}
var fromSeq int64 // Spanner doesn't support uint64
var rootHash []byte
Expand Down
Loading