Allow witness signature collection to fail open #634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This field is now only used within the package, and not by storage implementations, so no need for a getter anymore.
mhutchinson
approved these changes
May 12, 2025
| cp, err = wg.Witness(ctx, cp) | ||
| if err != nil { | ||
| return nil, err | ||
| if !o.witnessOpts.FailOpen { |
Contributor
There was a problem hiding this comment.
This should have metrics so that operators can safely determine when they are able to switch modes.
AlCutter
force-pushed
the
witness_fail_open
branch
5 times, most recently
from
d214fa6 to
788cab2
Compare
AlCutter
force-pushed
the
witness_fail_open
branch
from
788cab2 to
db837d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides what's intended to be a temporary mechanism to enable logs to interact with the witness network in a fail open fashion, whereby they will publish checkpoints & whatever valid witness signatures were obtained for it, regardless of whether the obtained signatures satisfy the specified witness policy.
With this option enabled logs and their clients can start to interact with the witness network in a safe "fail open" fashion as it develops and matures.