Skip to content

Remove Electron legacy code and stubs#1572

Open
aliasaria wants to merge 2 commits intomainfrom
claude/cleanup-electron-legacy-3Rgia
Open

Remove Electron legacy code and stubs#1572
aliasaria wants to merge 2 commits intomainfrom
claude/cleanup-electron-legacy-3Rgia

Conversation

@aliasaria
Copy link
Member

  • Delete unused Electron scripts: electron-rebuild.js, notarize.js, check-native-dep.js
  • Delete release/app/package.json (Electron packaging artifact)
  • Simplify preload-cloud.ts: remove dead ipcRenderer/electronHandler/autoUpdater stubs, keep window.platform and window.storage
  • Update check-build-exists.ts to check cloud build output instead of Electron main/renderer bundles
  • Remove Electron externals import from webpack base config
  • Clean up knip.json: remove electron-related ignoreDependencies
  • Remove browserslist-config-erb devDependency
  • Clean up .eslintignore and tsconfig.json: remove release/app/dist references

https://claude.ai/code/session_019nhPPfTJp75Sp5h33eHLF6

- Delete unused Electron scripts: electron-rebuild.js, notarize.js, check-native-dep.js
- Delete release/app/package.json (Electron packaging artifact)
- Simplify preload-cloud.ts: remove dead ipcRenderer/electronHandler/autoUpdater stubs, keep window.platform and window.storage
- Update check-build-exists.ts to check cloud build output instead of Electron main/renderer bundles
- Remove Electron externals import from webpack base config
- Clean up knip.json: remove electron-related ignoreDependencies
- Remove browserslist-config-erb devDependency
- Clean up .eslintignore and tsconfig.json: remove release/app/dist references

https://claude.ai/code/session_019nhPPfTJp75Sp5h33eHLF6
@paragon-review
Copy link

Paragon Review Skipped

Hi @aliasaria! Your Polarity credit balance is insufficient to complete this review.

Please visit https://home.polarity.cc to add more credits and continue using Paragon reviews.

Copy link
Member

@deep1401 deep1401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will probably merge this after build today to avoid any issues and we can let this sit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants