Fixed check if sourcefilename is valid#47
Merged
trampgeek merged 1 commit intotrampgeek:masterfrom Jan 31, 2021
mrlnstk:master
Merged
Fixed check if sourcefilename is valid#47trampgeek merged 1 commit intotrampgeek:masterfrom mrlnstk:master
trampgeek merged 1 commit intotrampgeek:masterfrom
mrlnstk:master
Conversation
Owner
|
Ouch, that's embarassing. Thanks for checking and fixing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the server checks if sourcefilename is valid it treats the run variable as an object but during the check the variable is not an object yet. So it will never check the filename.
This will fix #46