Add Ruby on Rails v6 example which uses Webpacker#197
Open
amree wants to merge 1 commit intotradingview:masterfrom
Open
Add Ruby on Rails v6 example which uses Webpacker#197amree wants to merge 1 commit intotradingview:masterfrom
amree wants to merge 1 commit intotradingview:masterfrom
Conversation
Add an example for Ruby on Rails v6 which uses webpacker to handle its javascript. The current example is the older version which uses an asset pipeline, so, a different example is needed for the newer version of Ruby on Rails.
amree
force-pushed
the
add-ruby-on-rails-v6-example
branch
from
0c83c49 to
43cfad0
Compare
timocov
suggested changes
Nov 27, 2020
Contributor
timocov
left a comment
timocov
left a comment
There was a problem hiding this comment.
Thanks for your contribution! Just few comments.
| @@ -0,0 +1,17 @@ | |||
| # README | |||
Contributor
There was a problem hiding this comment.
Can you please make readme file similar to https://github.com/tradingview/charting-library-examples/tree/master/ruby-on-rails?
| - Copy `charting_library/charting_library.js` into `app/javascript/packs/charting_library/charting_library.js` | ||
| - Copy `datafeeds/udf/dist/*.js` into `app/javascript/packs/datafeeds/` | ||
| - Copy `charting_library/*.html` into `public/charting_library/` | ||
| - Copy `charting_library/bundles` into `public/charting_library/bundles` |
Contributor
There was a problem hiding this comment.
It seems that we have to run yarn before run the app?
Contributor
There was a problem hiding this comment.
Also, is it possible to migrate to npm instead?
| @@ -0,0 +1 @@ | |||
| yvu8/Qw+RUlkD8CltYTm6GlzVF/3SVimkO6JG/Yp2mC4XL9JYU+QEGAwxfiL6YsIlyepj4EiKd42Qy76bWA6HfRtmktjS9pCfd6fwEyEJjdKa75V08Ui2xrwvHj42IKguf25v8/IW+iFMbm2wnXiYFuA0aOHQNhCXOf8PoCxqDJMlZcsJOYrGrmtm8EFwIJGOU8RYkUw1nWw9nL/MngNPFPQnvzyTcQUdEWqUUZwXKpaDMHWxncjZjn2acsLM8uvZwT5kByhjWp9rudhmFJh7k0zYwgMcPskTCv6rJ7t1xliMTbABzImAFcIMeUVv0/jdmgQBO6GmFZpfliD6Bw8Bu9PmTLXbivyVi4Iasl7PDoFEqNwO5xwUu+wx25p4NGFOHTx/dcrTOEdi7a4MCjmDs6QTAfcgIkcupR9--jmXkdcXEWEVobOEJ--iZuQgWRu9plT8TqWJTS0vg== No newline at end of file | |||
Contributor
There was a problem hiding this comment.
Is this auto-generated? How to (re-)generate it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an example for Ruby on Rails v6 which uses webpacker to handle its javascript. The current example is the older version which uses an asset pipeline, so, a different example is needed for the newer version of Ruby on Rails.
p/s: I can create two commits to make it clearer, one to create the project and the other is for adding TradingView's integration. I don't think we should update the current Ruby on Rails example. I think lots of people are still using that version.
Add example checklist
Bug fix checklist