Skip to content

Avoid recreation of virtualenv due to symlinks #2574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gaborbernat merged 1 commit into from
Dec 1, 2022
Merged

Avoid recreation of virtualenv due to symlinks #2574

gaborbernat merged 1 commit into from
Dec 1, 2022

Conversation

@ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Dec 1, 2022 •
edited
Loading

If people called tox alternating between python3 -m tox and tox,
they would endup triggering venv recreation, even if there was only
one python. We should always resolve symlinks to avoid such false
env invalidations.

Thanks for contribution

Please, make sure you address all the checklists (for details on how see
development documentation)!

  • ran the linter to address style issues (tox -e fix_lint)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

@ssbarnea ssbarnea added the bug:minor does not affect many people or has no big impact label Dec 1, 2022
@ssbarnea
Avoid recreation of virtualenv due to symlinks
3602420 
If people called tox alternating between `python3 -m tox` and `tox`,
they would endup triggering venv recreation, even if there was only
one python. We should always resolve symlinks to avoid such false
env invalidations.
@ssbarnea ssbarnea marked this pull request as ready for review December 1, 2022 09:49
@ssbarnea ssbarnea requested a review from gaborbernat as a code owner December 1, 2022 09:49
@ssbarnea
Copy link
Member Author

ssbarnea commented Dec 1, 2022

@gaborbernat I would have written a test but I am not sure how to test for that. Maybe you can indicate me an existing test that loads the info and we can check that executable is already resolved inside the file?

@ssbarnea ssbarnea added this to the 4.0 milestone Dec 1, 2022
@gaborbernat gaborbernat merged commit 4265ae1 into tox-dev:main Dec 1, 2022
@mikelane mikelane mentioned this pull request Dec 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gaborbernat gaborbernat gaborbernat approved these changes

Assignees

No one assigned

Labels

bot:chronographer:provided bug:minor does not affect many people or has no big impact

Projects

None yet

Milestone

4.0

Development

Successfully merging this pull request may close these issues.

2 participants

@ssbarnea @gaborbernat