Skip to content

Conversation

@ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Nov 22, 2022

Fixes: #2342

Thanks for contributing a pull request!

If you are contributing for the first time or provide a trivial fix don't worry too
much about the checklist - we will help you get started.

Contribution checklist:

(also see CONTRIBUTING.rst for details)

  • wrote descriptive pull request text
  • added/updated test(s)
  • updated/extended the documentation
  • added relevant issue keyword
    in message body
  • added news fragment in changelog folder
    • fragment name: <issue number>.<type>.rst for example (588.bugfix.rst)
    • <type> is must be one of bugfix, feature, deprecation, breaking, doc, misc
    • if PR has no issue: consider creating one first or change it to the PR number after creating the PR
    • "sign" fragment with -- by :user:`<your username>`.
    • please, use full sentences with correct case and punctuation, for example:
      Fixed an issue with non-ascii contents in doctest text files -- by :user:`superuser`.
    • also see examples
  • added yourself to CONTRIBUTORS (preserving alphabetical order)

@ssbarnea ssbarnea added the bug:minor does not affect many people or has no big impact label Nov 22, 2022
@ssbarnea ssbarnea added this to the 4.0 milestone Nov 22, 2022
@ssbarnea ssbarnea marked this pull request as ready for review November 22, 2022 23:39
@gaborbernat gaborbernat merged commit e9a8b2f into tox-dev:rewrite Nov 23, 2022
parsed = Parsed()
try:
tox_parser.parse_known_args(args, namespace=parsed)
with open(os.devnull, "w") as f:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should have added a test for this to be fair 🤦

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was planning to, but time... 🤷🏽‍♂️

@ssbarnea ssbarnea deleted the v4/noise branch November 26, 2022 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:provided bug:minor does not affect many people or has no big impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants