Skip to content

Conversation

@nhtsai
Copy link
Contributor

@nhtsai nhtsai commented Mar 24, 2022

Fixed incorrect youtube link. First time contributing, please let me know if any other changes need to be made. Thank you!

Contribution checklist:

(also see CONTRIBUTING.rst for details)

  • wrote descriptive pull request text
  • added/updated test(s)
  • updated/extended the documentation
  • added relevant issue keyword
    in message body
  • added news fragment in changelog folder
    • fragment name: <issue number>.<type>.rst for example (588.bugfix.rst)
    • <type> is must be one of bugfix, feature, deprecation, breaking, doc, misc
    • if PR has no issue: consider creating one first or change it to the PR number after creating the PR
    • "sign" fragment with -- by :user:`<your username>`.
    • please, use full sentences with correct case and punctuation, for example:
      Fixed an issue with non-ascii contents in doctest text files -- by :user:`superuser`.
    • also see examples
  • added yourself to CONTRIBUTORS (preserving alphabetical order)

@nhtsai nhtsai requested a review from gaborbernat as a code owner March 24, 2022 04:05
Copy link
Member

@jugmac00 jugmac00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for you contribution!

@jugmac00 jugmac00 merged commit 6c519d6 into tox-dev:rewrite Mar 24, 2022
@nhtsai nhtsai deleted the patch-1 branch March 26, 2022 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants