Skip to content

Conversation

@jankeromnes
Copy link

Hi,

Here is what I did to the CREDITS file:

  • I removed some tailing spaces
  • I verified the alphabetical order, and found 3 errors
  • I corrected them

Sorry for the microscopic commit.

Sincerely,
Jan.

@Gunni
Copy link

Gunni commented Sep 22, 2011

I believe pull requests like this are not used.

https://github.com/torvalds/linux/blob/master/Documentation/HOWTO

I recommend reading that.

@jankeromnes
Copy link
Author

Thanks Gunni!

Now that I have read my way through the documentation, three small questions before I close this:

  • Should I send my (protocol appliant) email to [email protected]?
  • The CREDITS file seems to have no maintainers. Can I help by maintaining this file?
  • Should my email contain a patch, or can it be a link to my github clone?

@sc68cal
Copy link
Contributor

sc68cal commented Sep 22, 2011

This is considered a trivial patch. Please consult MAINTAINERS and Documentation/SubmittingPatches for the person responsible and how to submit patches. Kernel.org is down right now, so [email protected] does not work. You can contact the current trivial patch maintainer at [email protected]

@Gunni
Copy link

Gunni commented Sep 22, 2011

Well, according to https://github.com/torvalds/linux/blob/master/Documentation/SubmittingPatches#L200 you should mail Jiri Kosina [email protected].

https://github.com/torvalds/linux/blob/master/MAINTAINERS#L6515

However since kernel.org is down i can not say where this should be sent, maybe use vger as a replacement and note that you're mailing there because the correct mail is down.

EDIT: yeah or use the mail sc68cal submitted: Jiri Kosina [email protected].

@jankeromnes
Copy link
Author

Thanks a lot! I'll email my patch to Jiri Kosina.

@sc68cal
Copy link
Contributor

sc68cal commented Sep 22, 2011

You also need to amend your commit message to add a sign off line. You need that in the commit message or your patch will not be accepted. Check the docs for more info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants