[Spyre-Next] Use vllm version from [tool.uv.sources]#866
Merged
sducouedic merged 3 commits intotorch-spyre:mainfrom Mar 25, 2026
Merged
[Spyre-Next] Use vllm version from [tool.uv.sources]#866sducouedic merged 3 commits intotorch-spyre:mainfrom
sducouedic merged 3 commits intotorch-spyre:mainfrom
Conversation
Signed-off-by: Sophie du Couédic <sop@zurich.ibm.com>
|
👋 Hi! Thank you for contributing to vLLM support on Spyre. We also recommend installing prek and configuring it to check your code before every local commit. |
github-actions
Bot
changed the title
Signed-off-by: Sophie du Couédic <sop@zurich.ibm.com>
Collaborator
Author
|
bot:next-test |
…sion" This reverts commit 28b4407. Signed-off-by: Sophie du Couédic <sop@zurich.ibm.com>
sducouedic
force-pushed
the
vllm_version
branch
from
90af877 to
3d2ac4e
Compare
Collaborator
Author
|
bot:next-test |
tjohnson31415
approved these changes
Mar 25, 2026
Collaborator
tjohnson31415
left a comment
tjohnson31415
left a comment
There was a problem hiding this comment.
LGTM. The value here didn't have any effect in my testing, so this is a good cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The current version of vllm dependency (v0.15.1) is wrong and conflicting with the version 0.17.1 specified in
[tool.uv.sources]. That latter one should be used. We can remove the version specification entirely independencies = [...to have the version in a single place.Test Plan
bot:next-test should still have two tests passing
Checklist
bash format.sh)Signed-off-by:line (DCO compliance)