⚡ find tests that can be unforked#856
Merged
joerunde merged 3 commits intotorch-spyre:mainfrom Mar 30, 2026
Merged
Conversation
Signed-off-by: Joe Runde <joe@joerun.de>
|
👋 Hi! Thank you for contributing to vLLM support on Spyre. We also recommend installing prek and configuring it to check your code before every local commit. |
maxdebayser
reviewed
Mar 21, 2026
|
|
||
| This is useful for running subsets of tests without requiring `--forked`. | ||
| Generally, we can't mix and match different vllm usage patterns within the same pytest process | ||
| without running into problems with relelasing spyre cards or crashing the compiler. |
Collaborator
There was a problem hiding this comment.
typo: relelasing -> releasing
sducouedic
reviewed
Mar 23, 2026
Co-authored-by: Sophie du Couédic <sop@zurich.ibm.com> Signed-off-by: Joe Runde <joe@joerun.de>
Signed-off-by: Joe Runde <joe@joerun.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a little sidequest inspired by @toddllm to make our tests run faster in CI. This PR marks tests by the type of cache that they use, and whether or not forking is strictly required for them.
This allows us to run tests that use the same type of vllm model cache without
--forked, which saves a huge amount of time skipping spyre warmup for tests that hit the model cache.Related Issues
Test Plan
As-is this doesn't change any behavior as the marking is strictly additive and none of these marks are used by our CI jobs currently.
We'll need to sync this with changes to the CI jobs to ensure that removing
--forkedfor these cases actually works. I've manually verified that I can run both:on this branch without failure.
Checklist
bash format.sh)Signed-off-by:line (DCO compliance)