Model config_format and tokenizer_mode conditional defaults fix#1027
Merged
joerunde merged 8 commits intoJul 15, 2026
Conversation
Signed-off-by: Daniel Schenker <daniel.schenker@ibm.com>
Signed-off-by: Daniel Schenker <daniel.schenker@ibm.com>
Signed-off-by: Daniel Schenker <daniel.schenker@ibm.com>
Signed-off-by: Daniel Schenker <daniel.schenker@ibm.com>
Signed-off-by: Daniel Schenker <daniel.schenker@ibm.com>
|
👋 Hi! Thank you for contributing. We also recommend installing prek and configuring it to check your code before every local commit. |
68ebed5 to
7424b64
Compare
Signed-off-by: Daniel Schenker <daniel.schenker@ibm.com>
Signed-off-by: Daniel Schenker <daniel.schenker@ibm.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the logic used to apply conditional defaults for
config_formatandtokenizer_mode.The previous implementation was incorrectly assigning mistral formatting to Llama models from HF as it was recursively searching the model files for a
params.jsonfile which was present in a subdirectory of some Llama models.The new implementation uses
is_mistral_model_repowhich checks forconsolidated*.safetensorsfile which is a more accurate check for mistral models.Related Issues
Test Plan
Tested with various supported models and it correctly detects mistral for supported mistral family models while defaulting to auto for non-mistral models.
Checklist
bash format.sh)Signed-off-by:line (DCO compliance)