SWA Granite HF registration#1017
Conversation
Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
|
👋 Hi! Thank you for contributing. We also recommend installing prek and configuring it to check your code before every local commit. |
Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
joerunde
left a comment
There was a problem hiding this comment.
We could consider adding a test here that loads a model config with granite_swa model_type to flex these code paths. (That might require whipping up a super tiny dummy model, which our good friend claude is also pretty good at.)
Not totally required for the initial merge here, but I would lean towards including because we've shipped a lot of regressions in the past for models like mistral that we didn't have load-path test cases for in the github CI
Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
|
Thanks for reviewing! Added some tests and hit auto-merge :) |
Description
Drops the dependency on the granite-swa-model transformers fork. Routes
granite_swathrough the generic FMS hf_pretrained/hf_configured path. Pairs with this FMS registration PR.Related Issues
none
Test Plan
none
Checklist
bash format.sh)Signed-off-by:line (DCO compliance)