Skip to content

SWA Granite HF registration#1017

Merged
yannicks1 merged 26 commits into
torch-spyre:mainfrom
yannicks1:swa_granite_adapt_hf
Jul 15, 2026
Merged

SWA Granite HF registration#1017
yannicks1 merged 26 commits into
torch-spyre:mainfrom
yannicks1:swa_granite_adapt_hf

Conversation

@yannicks1

@yannicks1 yannicks1 commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Description

Drops the dependency on the granite-swa-model transformers fork. Routes granite_swa through the generic FMS hf_pretrained/hf_configured path. Pairs with this FMS registration PR.

Related Issues

none

Test Plan

none

Checklist

  • I have read the contributing guidelines
  • My code follows the project's code style (run bash format.sh)
  • I have added tests for my changes (if applicable)
  • I have updated the documentation (if applicable)
  • My commits include a Signed-off-by: line (DCO compliance)

yannicks1 added 22 commits May 15, 2026 16:59
Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
@github-actions

Copy link
Copy Markdown

👋 Hi! Thank you for contributing.
Just a reminder: Make sure that your code passes all the linting checks, otherwise your PR won't be able to be merged. To do so, run ./format.sh.
Now you are good to go 🚀.

We also recommend installing prek and configuring it to check your code before every local commit.

Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
@yannicks1 yannicks1 marked this pull request as ready for review July 14, 2026 13:27
@yannicks1 yannicks1 changed the title [WIP] SWA Granite HF registration SWA Granite HF registration Jul 14, 2026

@joerunde joerunde left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could consider adding a test here that loads a model config with granite_swa model_type to flex these code paths. (That might require whipping up a super tiny dummy model, which our good friend claude is also pretty good at.)

Not totally required for the initial merge here, but I would lean towards including because we've shipped a lot of regressions in the past for models like mistral that we didn't have load-path test cases for in the github CI

Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
Signed-off-by: Yannick Schnider <Yannick.Schnider1@ibm.com>
@yannicks1 yannicks1 enabled auto-merge (squash) July 15, 2026 09:51
@github-actions github-actions Bot added the ready Runs the full CI test suite. Only add to PRs once ready to merge to limit public GHA usage label Jul 15, 2026
@yannicks1

Copy link
Copy Markdown
Collaborator Author

Thanks for reviewing! Added some tests and hit auto-merge :)

@yannicks1 yannicks1 merged commit 7806c35 into torch-spyre:main Jul 15, 2026
15 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready Runs the full CI test suite. Only add to PRs once ready to merge to limit public GHA usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants