npm package #4
Open
npm package #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Releases are now versioned in the browser directory * Added package.json for npm/browserify * scrypt releases are wrapped with UMD * Uses a mustache template instead of prefix and suffix files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I changed a lot here and am not sure if this is the direction you want to take the project...
Initially I wanted to clean up the build and get things setup to be on npm so it would work better with the browserify workflow as well as pave the way for a test+benchmark suite I am about to work on for opal.io (noticed problems in Safari 7.0)
A few keypoints:
scryptis the exported module and has ascrypt.create(total_mem)function for exposing the factory.My Makefile chops are probably not the smoothest and I am not super familiar with working with emscripten. The diff of my compiled version of srcypt was different than the one you have but I am assuming emscripten picks random var names etc.
Let me know if you want me to change anything. Thanks for making this available :)