Skip to content

fix(tolk/completion): don't show type parameter in value completion #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
i582 merged 1 commit into from
Jul 22, 2025
Merged

fix(tolk/completion): don't show type parameter in value completion #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions server/src/e2e/tolk/testcases/completion/local.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,3 +107,12 @@ fun foo() {
------------------------------------------------------------------------
5 some int
5 someOther slice

========================================================================
No type parameters completion as value
========================================================================
fun foo<TName, TName2>() {
TNam<caret>;
}
------------------------------------------------------------------------
No completion items
2 changes: 2 additions & 0 deletions server/src/languages/tolk/completion/ReferenceCompletionProcessor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@ export class ReferenceCompletionProcessor implements ScopeProcessor {
}
}

if (node instanceof TypeParameter) return false

// since structs can be created like `Foo{}` we allow them
if (node instanceof Struct) return true
return true
Expand Down
Loading