fix: handle breaking changes when current version is dev#308
Draft
KevinDeJong-TomTom wants to merge 3 commits intomasterfrom
Draft
fix: handle breaking changes when current version is dev#308KevinDeJong-TomTom wants to merge 3 commits intomasterfrom
KevinDeJong-TomTom wants to merge 3 commits intomasterfrom
Conversation
This commit restructures the SdkVer handling based on use-case
mapping, simplifying the overall complexity of maintaining the
flow.
This was needed to tackle the specific use case for failure of
creating a new breaking change from a `dev` or `rc` version.
i.e. `1.0.0-dev001.SHA` could not lead to `2.0.0-rc01` even
when specifying that this is a breaking change.
| ); | ||
| } | ||
|
|
||
| /** |
Collaborator
Author
There was a problem hiding this comment.
This file is unmodified from this point onwards...
| @@ -0,0 +1,468 @@ | |||
| /** | |||
Collaborator
Author
There was a problem hiding this comment.
This file contains the SemVer bump functions, originally part of bump.ts - no changes to code have been applied
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit restructures the SdkVer handling based on use-case mapping, simplifying the overall complexity of maintaining the flow.
This was needed to tackle the specific use case for failure of creating a new breaking change from a
devorrcversion.i.e.
1.0.0-dev001.SHAcould not lead to2.0.0-rc01evenwhen specifying that this is a breaking change.