Bug: uosc's mouse event processing does not respect the OSD menu inside mpv

[dyphire]

As the title states, uosc's mouse event processing currently does not respect the OSD menu drawn by mpv internal scripts input.lua and context_menu.lua.
When the internal OSD menu triggers the window boundary area, it will evoke the UI element of uosc and disable the function of the corresponding OSD menu area. This will not happen in the mpv official OSC or ModernZ.

See also mpv-player/mpv#17428. I initially thought this was only happening with context_menu, then noticed that it also appears in all OSD menus drawn by mp.input. This is an issue that needs to be fixed by uosc.

[tomasklaen]

I'm not keeping up with new mpv stuff that much. What needs to happen in uosc to work nicely with the new mpv context menu? Should we just ignore all mouse events when user-data/mpv/context-menu/open is true?

[dyphire]

I'm not keeping up with new mpv stuff that much. What needs to happen in uosc to work nicely with the new mpv context menu? Should we just ignore all mouse events when user-data/mpv/context-menu/open is true?

No, that doesn't solve the problem. As I mentioned above, in addition to the new mpv context menu, uosc also affects all menus drawn by mp.input, which are not controlled by user-data/mpv/context-menu/open.

The fundamental reason is that uosc handles mouse events differently from mpv official OSC, and one of the differences causes this problem.

If the handling of mouse events in uosc is difficult to modify to imitate the official OSC behavior of mpv, then compatibility can be achieved through the following patch after the upstream PR of mpv is merged:

---
 scripts/uosc/elements/Curtain.lua | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/scripts/uosc/elements/Curtain.lua b/scripts/uosc/elements/Curtain.lua
index ccebfb0..ef8e873 100644
--- a/scripts/uosc/elements/Curtain.lua
+++ b/scripts/uosc/elements/Curtain.lua
@@ -9,6 +9,23 @@ function Curtain:init()
 	self.opacity = 0
 	---@type string[]
 	self.dependents = {}
+
+	-- Monitor context-menu open state
+	self:observe_mp_property('user-data/mpv/context-menu/open', function(_, value)
+		if value == true then
+			self:register('context-menu')
+		else
+			self:unregister('context-menu')
+		end
+	end)
+	-- Monitor console open state
+	self:observe_mp_property('user-data/mpv/console/open', function(_, value)
+		if value == true then
+			self:register('console')
+		else
+			self:unregister('console')
+		end
+	end)
 end
 
 ---@param id string
-- 

[guidocella]

The difference between builtin scripts and uosc is just that it doesn't add the MOUSE_MOVE keybinding, instead it directly observes mouse-pos.

[tomasklaen]

The difference between builtin scripts and uosc is just that it doesn't add the MOUSE_MOVE keybinding, instead it directly observes mouse-pos.

We've had a reason for doing that. I think it was interoperability with other scripts.

[hooke007]

We've had a reason for doing that.

#295

[guidocella]

Yeah the builtin OSC conflicts with drag to pan instead. It only works in the deadzone due to using mp.set_mouse_area(). (In mpv-player/mpv#15346, I set script-opt=osc-deadzonesize=0.9 to images for this reason.)