Made overflow far less likely on Windows. #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaka
added a commit
that referenced
this pull request
Mar 5, 2015
Made overflow far less likely on Windows.
|
You may also be interested in the fix applied to the standard library: rust-lang/rust#22788 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shouldn't have been wrapping in the first place, as doing the operations in the other order makes this far less likely to happen. Downstream users like event_loop need this not to wrap over time; if it does it will cause serious bugs, so a panic would be much preferred for now.
I tested this and the overflows don't happen anymore, and on Windows my event loop stopped freezing. (It was wrapping every ~30 minutes, crashing my app.)