subscriber: split reload handle and filter tests #2803
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two tests for the reload subscriber which are in the same test module. However, these two tests both check the value of `LevelFilter::current()`, which is a global value. This caused flakiness in the tests, especially on CI. To ensure that we can safely test global values, these two tests have bit split into separate test modules. A doc comment has been added to each test explaining that it needs to remain in its own file.
Contributor
Author
|
#2798 Got merged instead, so we don't need this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There are two tests for the reload subscriber which are in the same test
module. However, these two tests both check the value of
LevelFilter::current(), which is a global value.This caused flakiness in the tests, especially on CI.
Solution
To ensure that we can safely test global values, these two tests have
bit split into separate test modules. A doc comment has been added to
each test explaining that it needs to remain in its own file.
This change is inspired by #2798. Big thanks to @SpeedReach for
determining the reason for the flakiness!