Skip to content

runtime: fix TOCTOU issue when decreasing num_idle_threads #7918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ADD-SP merged 3 commits into from
Feb 18, 2026
+4 −4
Merged

runtime: fix TOCTOU issue when decreasing num_idle_threads #7918

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5bae31e
runtime: fix TOCTOU issue when decreasing `num_idle_threads`
ADD-SP Feb 17, 2026
19bdfab
add the assertion back and fix it
ADD-SP Feb 17, 2026
966b97b
fix rustfmt reports
ADD-SP Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions tokio/src/runtime/blocking/pool.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -568,14 +568,7 @@ impl Inner {
// Thread exit
self.metrics.dec_num_threads();

// num_idle should now be tracked exactly, panic
// with a descriptive message if it is not the
// case.
let prev_idle = self.metrics.dec_num_idle_threads();
assert!(
prev_idle >= self.metrics.num_idle_threads(),
"num_idle_threads underflowed on thread exit"
);
self.metrics.dec_num_idle_threads();

if shared.shutdown && self.metrics.num_threads() == 0 {
self.condvar.notify_one();
Expand Down
Loading