Skip to content

codec: remove unnecessary trait bounds on all Framed constructors #7716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 29, 2025
Merged

codec: remove unnecessary trait bounds on all Framed constructors #7716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b516e3
remove unnecessary bounds on Framed constructors
conradludgate Oct 29, 2025
d2a5d88
merge impl blocks
conradludgate Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions tokio-util/src/codec/framed.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,7 @@ pin_project! {
}
}

impl<T, U> Framed<T, U>
where
T: AsyncRead + AsyncWrite,
{
impl<T, U> Framed<T, U> {
/// Provides a [`Stream`] and [`Sink`] interface for reading and writing to this
/// I/O object, using [`Decoder`] and [`Encoder`] to read and write the raw data.
///
Expand Down Expand Up @@ -127,9 +124,7 @@ where
},
}
}
}

impl<T, U> Framed<T, U> {
/// Provides a [`Stream`] and [`Sink`] interface for reading and writing to this
/// I/O object, using [`Decoder`] and [`Encoder`] to read and write the raw data.
///
Expand Down
8 changes: 1 addition & 7 deletions tokio-util/src/codec/framed_read.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,7 @@ pin_project! {

// ===== impl FramedRead =====

impl<T, D> FramedRead<T, D>
where
T: AsyncRead,
D: Decoder,
{
impl<T, D> FramedRead<T, D> {
/// Creates a new `FramedRead` with the given `decoder`.
pub fn new(inner: T, decoder: D) -> FramedRead<T, D> {
FramedRead {
Expand Down Expand Up @@ -68,9 +64,7 @@ where
},
}
}
}

impl<T, D> FramedRead<T, D> {
/// Returns a reference to the underlying I/O stream wrapped by
/// `FramedRead`.
///
Expand Down
7 changes: 1 addition & 6 deletions tokio-util/src/codec/framed_write.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,7 @@ pin_project! {
}
}

impl<T, E> FramedWrite<T, E>
where
T: AsyncWrite,
{
impl<T, E> FramedWrite<T, E> {
/// Creates a new `FramedWrite` with the given `encoder`.
pub fn new(inner: T, encoder: E) -> FramedWrite<T, E> {
FramedWrite {
Expand All @@ -64,9 +61,7 @@ where
},
}
}
}

impl<T, E> FramedWrite<T, E> {
/// Returns a reference to the underlying I/O stream wrapped by
/// `FramedWrite`.
///
Expand Down