task: add size check for user-supplied future#6692
Merged
mox692 merged 3 commits intotokio-rs:masterfrom Jul 18, 2024
Merged
Conversation
Altiboy
approved these changes
Jul 17, 2024
Darksonn
approved these changes
Jul 17, 2024
Member
Darksonn
left a comment
Darksonn
left a comment
There was a problem hiding this comment.
It's a bit hard for me to tell whether you've added the check in all of the right places, but looks reasonable.
tokio/src/runtime/mod.rs
Outdated
Comment on lines
+388
to
+390
| /// Boundary value to prevent stack overflow caused by a large-sized | ||
| /// Future being placed in the stack. | ||
| pub(crate) const MAX_FUTURE_SIZE: usize = 2048; |
Member
There was a problem hiding this comment.
It's not really a maximum for the future size.
Suggested change
| /// Boundary value to prevent stack overflow caused by a large-sized | |
| /// Future being placed in the stack. | |
| pub(crate) const MAX_FUTURE_SIZE: usize = 2048; | |
| /// Boundary value to prevent stack overflow caused by a large-sized | |
| /// Future being placed in the stack. | |
| pub(crate) const BOX_FUTURE_THRESHOLD: usize = 2048; |
This was referenced Jul 22, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6673.
Like #4009, this PR adds a size check logic for public apis that accepts user-provided futures so that large futures are not repeatedly passed to the function and exhaust the stack.
Also, this extracts commonly used constant.