metrics: rename num_active_tasks to num_alive_tasks#6667
Merged
Conversation
Darksonn
added
A-tokio
github-actions
bot
added
R-loom-current-thread
conradludgate
approved these changes
Jun 30, 2024
hds
approved these changes
Jun 30, 2024
Contributor
hds
left a comment
hds
left a comment
There was a problem hiding this comment.
Name change makes sense. It's clearer this way.
This was referenced Jul 22, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The word "active" is the opposite of "idle", but an "idle task" normally refers to a task that is alive but not currently able to make progress. However, idle tasks are included in this counter.
Instead of "active", I propose the name "alive".