Skip to content

chore: Relax MSRV #983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
+23 −6
Closed

chore: Relax MSRV #983

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a04f72
chore: Add ci to check msrv for each crate
tottoto Feb 17, 2024
7e4f10b
chore: Relax MSRV
tottoto Feb 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
matrix:
toolchain:
- stable
- "1.70"
- "1.70" # max version of msrv
os:
- ubuntu-latest
- macos-latest
Expand Down Expand Up @@ -68,6 +68,21 @@ jobs:
- name: test doc no-default-features
run: cargo test -p prost-build -p prost-derive -p prost-types --doc --no-default-features

msrv:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: install protoc
uses: taiki-e/install-action@v2
with:
tool: protoc@${{ env.PROTOC_VERSION }}
- uses: taiki-e/install-action@cargo-hack
- uses: Swatinem/rust-cache@v2
- name: check with no-default-features
run: cargo hack --rust-version --no-private --no-dev-deps check --workspace --no-default-features
- name: check with all-features
run: cargo hack --rust-version --no-private --no-dev-deps check --workspace --all-features

minimal-versions:
runs-on: ubuntu-latest
steps:
Expand Down
2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ description = "A Protocol Buffers implementation for the Rust Language."
keywords = ["protobuf", "serialization"]
categories = ["encoding"]
edition = "2021"
rust-version = "1.70"
rust-version = "1.60"

[workspace]
members = [
Expand Down
6 changes: 4 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,10 @@ See the [snazzy repository][snazzy] for a simple start-to-finish example.

### MSRV

`prost` follows the `tokio-rs` project's MSRV model and supports 1.70. For more
information on the tokio msrv policy you can check it out [here][tokio msrv]
`prost` follows the `tokio-rs` project's MSRV model and supports 1.70. Some
crates' MSRV might be lower than this version, see each `rust-version` field of
the manifest file. For more information on the tokio msrv policy you can check
it out [here][tokio msrv]

[tokio msrv]: https://github.com/tokio-rs/tokio/#supported-rust-versions

Expand Down
2 changes: 1 addition & 1 deletion prost-derive/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ documentation = "https://docs.rs/prost-derive"
readme = "README.md"
description = "A Protocol Buffers implementation for the Rust Language."
edition = "2021"
rust-version = "1.70"
rust-version = "1.60"

[lib]
proc_macro = true
Expand Down
2 changes: 1 addition & 1 deletion prost-types/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ documentation = "https://docs.rs/prost-types"
readme = "README.md"
description = "A Protocol Buffers implementation for the Rust Language."
edition = "2021"
rust-version = "1.70"
rust-version = "1.60"

[lib]
doctest = false
Expand Down