build(deps): Depend on multimap 0.8 or 0.9 #958
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucioFranco
reviewed
Jan 5, 2024
| itertools = { version = "0.10", default-features = false, features = ["use_alloc"] } | ||
| log = "0.4" | ||
| multimap = { version = "0.8", default-features = false } | ||
| multimap = { version = ">=0.8, <0.10", default-features = false } |
Contributor
There was a problem hiding this comment.
Personally, I think this syntax explains better the intent of the version bounds.
Suggested change
| multimap = { version = ">=0.8, <0.10", default-features = false } | |
| multimap = { version = ">=0.8, <=0.9", default-features = false } |
caspermeijn
reviewed
Feb 23, 2024
Contributor
caspermeijn
left a comment
caspermeijn
left a comment
There was a problem hiding this comment.
Please rebase on the latest master branch. It seems multimap 0.10 has been released since the creation of this PR.
| itertools = { version = "0.10", default-features = false, features = ["use_alloc"] } | ||
| log = "0.4" | ||
| multimap = { version = "0.8", default-features = false } | ||
| multimap = { version = ">=0.8, <0.10", default-features = false } |
Contributor
There was a problem hiding this comment.
Personally, I think this syntax explains better the intent of the version bounds.
Suggested change
| multimap = { version = ">=0.8, <0.10", default-features = false } | |
| multimap = { version = ">=0.8, <=0.9", default-features = false } |
Contributor
|
Fixed in #1013 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depend on
multimapversion 0.8 or 0.9.