Fix invalid fq_message_name when appending nested message in empty package
#845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldm0
force-pushed
the
ldm_package_fix
branch
2 times, most recently
from
874e711 to
978698c
Compare
ldm0
force-pushed
the
ldm_package_fix
branch
from
978698c to
3292d62
Compare
Contributor
|
This has been fixed by #981 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On appending nested message, if package is empty, wrong
fq_message_nameis generated(e.g...M.SubMessagein this case), which leads to codegen failure. MakingCodeGenerator::packagevec and removing the string hacks solve this issue.fixes #843