Skip to content

style: Remove needless borrow #1122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 16, 2024
Merged

style: Remove needless borrow #1122

merged 1 commit into from
Aug 16, 2024

Conversation

@caspermeijn
Copy link
Contributor

@caspermeijn caspermeijn commented Aug 16, 2024 

warning: the borrowed expression implements the required traits
   --> protobuf/build.rs:143:14
    |
143 | ...rg(&format!("-DCMAKE_INSTALL_PREFIX={}", prefix_dir.display(...
    |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("-DCMAKE_INSTALL_PREFIX={}", prefix_dir.display())`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
    = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default

@caspermeijn caspermeijn force-pushed the clippy branch 2 times, most recently from c63d24f to 8c76573 Compare August 16, 2024 10:01
@caspermeijn
style: Remove needless borrow
c4ff9a1 
`cargo clippy` reports:
```
warning: the borrowed expression implements the required traits
   --> protobuf/build.rs:143:14
    |
143 | ...rg(&format!("-DCMAKE_INSTALL_PREFIX={}", prefix_dir.display(...
    |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("-DCMAKE_INSTALL_PREFIX={}", prefix_dir.display())`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
    = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
```
@caspermeijn caspermeijn added this pull request to the merge queue Aug 16, 2024
Merged via the queue into tokio-rs:master with commit 409b932 Aug 16, 2024
@caspermeijn caspermeijn deleted the clippy branch August 16, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@caspermeijn