Skip to content

fix(prost-types): Parse timestamp with long second fraction #1106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2024
Merged

fix(prost-types): Parse timestamp with long second fraction #1106

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions prost-types/src/datetime.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,8 +260,10 @@ fn parse_nanos(s: &str) -> Option<(u32, &str)> {

// Parse the nanoseconds, if present.
let (nanos, s) = if let Some(s) = parse_char(s, b'.') {
let (digits, s) = parse_digits(s);
ensure!(digits.len() <= 9);
let (mut digits, s) = parse_digits(s);
if digits.len() > 9 {
digits = digits.split_at(9).0;
}
let nanos = 10u32.pow(9 - digits.len() as u32) * digits.parse::<u32>().ok()?;
(nanos, s)
} else {
Expand Down Expand Up @@ -791,7 +793,13 @@ mod tests {
assert_eq!(
"19+1-+2-+3T+4:+5:+6Z".parse::<Timestamp>(),
Err(crate::TimestampError::ParseFailure),
)
);

// Very long seconds fraction
assert_eq!(
"1343-08-16 18:33:44.1666666666666666666666666666666666666666666666666666666666666666666666666666666666666666666666666666666666666666666666666660404z".parse::<Timestamp>(),
Timestamp::date_time_nanos(1343, 8, 16, 18, 33, 44, 166_666_666),
);
}

#[test]
Expand Down