fix(prost-types): '+' is not a numeric digit #1104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mumbleskates
force-pushed
the
two-actual-digits
branch
from
309bbbd to
f7530f1
Compare
caspermeijn
approved these changes
Jul 13, 2024
Contributor
caspermeijn
left a comment
caspermeijn
left a comment
There was a problem hiding this comment.
Good find. Thanks for your contribution!
| if s.len() < 2 { | ||
| return None; | ||
| } | ||
| if s.starts_with('+') { |
Contributor
There was a problem hiding this comment.
The digits.parse function will eventually call u8::from_str_radix, which allows to an optional + and then only digits. So checking for the + as the first character is enough to get all the weird cases of parse.
Contributor
Author
There was a problem hiding this comment.
yep, that seems to be the case!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
u8 as FromStrtolerates a leading+character, so before this change for any 2-digit component of the path, "05" and "+5" are basically equivalent. we shouldn't tolerate this, it's weird.