build: Ignore missing features in tests crates
#1101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only the crate `tests-2015` uses the feature `edition-2015`, but the code is shared with the `tests` crate.
Same for `tests-no-std` which disables feature `std`, but reuses the code with the `tests` crate.
Therefore the `tests`, `tests-2018` and `tests-no-std` crates should be configured to ignore the lint about missing features.
Cargo clippy reports:
```
warning: unexpected `cfg` condition value: `edition-2015`
--> tests-no-std/../tests/src/build.rs:5:14
|
5 | if #[cfg(feature = "edition-2015")] {
| ^^^^^^^-----------------
| |
| help: remove the condition
|
= note: no expected values for `feature`
= help: consider adding `edition-2015` as a feature in `Cargo.toml`
= note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
= note: `#[warn(unexpected_cfgs)]` on by default
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only the crate
tests-2015uses the featureedition-2015, but the code is shared with thetestscrate.Same for
tests-no-stdwhich disables featurestd, but reuses the code with thetestscrate.Therefore the
tests,tests-2018andtests-no-stdcrates should be configured to ignore the lint about missing features.Cargo clippy reports: