Add FromExtractor and deprecate extractor_middleware - #957
Merged
Conversation
jplatte
suggested changes
Apr 22, 2022
Contributor
There was a problem hiding this comment.
Thanks for working in this!
You seem to have run some formatting on the changelog, please undo those (unrelated) changes.
Also, in addition to the function, the layer and response future type are also part of the public API and need to stay accessible under their old paths / names (as re-exports) to maintain backwards compatibility.
jplatte
approved these changes
Apr 23, 2022
davidpdrsn
requested changes
Apr 24, 2022
davidpdrsn
left a comment
davidpdrsn
left a comment
Member
There was a problem hiding this comment.
Thanks!
Wanna add an #[allow(deprecated)] to axum/src/extract/mod.rs to fix the warnings shown in GitHub?
davidpdrsn
approved these changes
Apr 24, 2022
davidpdrsn
enabled auto-merge (squash)
April 24, 2022 15:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #954