Add accessors to TypedHeaderRejection fields - #317
Merged
davidpdrsn merged 4 commits intoSep 12, 2021
Merged
Conversation
3olkin
reviewed
Sep 12, 2021
3olkin
left a comment
3olkin
left a comment
Contributor
There was a problem hiding this comment.
Reason type should be exportable for having possibility to handle different reasons manually.
So those changes are not enough because typed_header module is private and all rejections is public from axum::extract::rejection.
IMHO simply reimport Reason type in rejection mode will be at least strange. So probably better way is making public only header name.
davidpdrsn
requested changes
Sep 12, 2021
davidpdrsn
approved these changes
Sep 12, 2021
davidpdrsn
left a comment
davidpdrsn
left a comment
Member
There was a problem hiding this comment.
Great! Thanks 😊 Wanna put a line in the changelog as well?
davidpdrsn
changed the title
davidpdrsn
changed the title
TypedHeaderRejection fields
Contributor
Author
|
Added the changelog entry as well |
davidpdrsn
enabled auto-merge (squash)
September 12, 2021 16:00
davidpdrsn
added a commit
that referenced
this pull request
Sep 18, 2021
Merged
davidpdrsn
added a commit
that referenced
this pull request
Sep 18, 2021
saad-aistack
added a commit
to saad-aistack/rust-high-perf-api
that referenced
this pull request
Mar 26, 2026
- Add accessors for `TypedHeaderRejection` fields ([#317]) - Improve docs for extractors ([#327]) [#317]: tokio-rs/axum#317 [#327]: tokio-rs/axum#327
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #316.
Allows to implement a custom extractor that can behave depending on the header rejection's details (name and reason).
More details in the original issue.
Solution
Reasontype publicly, because this doesn't compile otherwise.