Add on_failed_upgrade callback to WebSocketUpgrade - #1539
Merged
Conversation
Previously if upgrading a connection to a WebSocket connection failed the background task would panic. There was no way to customize that so users that might wanna report the error was out of luck. Panicking also wasn't great because users might abort on panics which would bring down the server.
davidpdrsn
changed the title
on_failed_upgrade callback to WebSocketon_failed_upgrade callback to WebSocketUpgrade
jplatte
approved these changes
Nov 18, 2022
Co-authored-by: Jonas Platte <jplatte+git@posteo.de>
davidpdrsn
enabled auto-merge (squash)
November 18, 2022 10:45
jplatte
approved these changes
Nov 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously if upgrading a connection to a WebSocket connection failed the background task would panic. There was no way to customize that so users that might wanna report the error was out of luck.
Panicking also wasn't great because users might abort on panics which would bring down the server.