Add accept_unmasked_frames setting in WebSocketUpgrade - #1529
Merged
Conversation
davidpdrsn
reviewed
Nov 14, 2022
davidpdrsn
left a comment
davidpdrsn
left a comment
Member
There was a problem hiding this comment.
Thanks! Wanna add a note to the changelog as well?
Contributor
Author
Done |
davidpdrsn
reviewed
Nov 15, 2022
davidpdrsn
enabled auto-merge (squash)
November 15, 2022 08:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
I am working with some legacy websocket clients that do not follow RFC 6455 and is thus sending unmasked frames via websockets. There isn't a way to change these clients, but tungstenite does expose an accept_unmasked_frames config option which can be set by axum.
Solution
I've added accept_unmasked_frames to WebSocketUpgrade to set the underlying config setting and allow unmasked frames
Please let me know if anything needs to change