Fix query extractor given an bad request error when query string is empty. - #117
Merged
Conversation
sunli829
force-pushed
the
main
branch
2 times, most recently
from
August 4, 2021 12:57
2d3c086 to
4c49ae6
Compare
sunli829
commented
Aug 4, 2021
sunli829
marked this pull request as ready for review
August 4, 2021 12:59
sunli829
marked this pull request as draft
August 4, 2021 13:01
sunli829
marked this pull request as ready for review
August 4, 2021 13:05
sunli829
marked this pull request as draft
August 4, 2021 14:02
sunli829
commented
Aug 4, 2021
sunli829
marked this pull request as ready for review
August 4, 2021 14:08
davidpdrsn
reviewed
Aug 4, 2021
davidpdrsn
approved these changes
Aug 4, 2021
davidpdrsn
left a comment
davidpdrsn
left a comment
Member
There was a problem hiding this comment.
Great! And thanks for adding tests 😊
One quick change to the wording of the changelog but otherwise it looks good!
sunli829
marked this pull request as draft
August 4, 2021 14:17
Contributor
Author
|
I removed |
sunli829
marked this pull request as ready for review
August 4, 2021 14:20
davidpdrsn
reviewed
Aug 4, 2021
sunli829
marked this pull request as draft
August 4, 2021 14:43
Contributor
Author
|
|
Member
|
Alright. Then lets just merge this without the deprecation. Then I'll look into it. |
…mpty. (tokio-rs#82) Co-Authored-By: David Pedersen <david.pdrsn@gmail.com>
sunli829
marked this pull request as ready for review
August 4, 2021 15:01
Contributor
Author
|
It's done now. 🙂 |
davidpdrsn
approved these changes
Aug 4, 2021
davidpdrsn
added a commit
that referenced
this pull request
Aug 4, 2021
Since #117 its no longer used. Will be removed in 0.2.
davidpdrsn
added a commit
that referenced
this pull request
Aug 4, 2021
davidpdrsn
added a commit
that referenced
this pull request
Aug 6, 2021
0.1.3 (06. August, 2021) - Fix stripping prefix when nesting services at `/` ([#91](#91)) - Add support for WebSocket protocol negotiation ([#83](#83)) - Use `pin-project-lite` instead of `pin-project` ([#95](#95)) - Re-export `http` crate and `hyper::Server` ([#110](#110)) - Fix `Query` and `Form` extractors giving bad request error when query string is empty. ([#117](#117)) - Add `Path` extractor. ([#124](#124)) - Fixed the implementation of `IntoResponse` of `(HeaderMap, T)` and `(StatusCode, HeaderMap, T)` would ignore headers from `T` ([#137](#137)) - Deprecate `extract::UrlParams` and `extract::UrlParamsMap`. Use `extract::Path` instead ([#138](#138))
Merged
davidpdrsn
added a commit
that referenced
this pull request
Aug 6, 2021
- Fix stripping prefix when nesting services at `/` ([#91](#91)) - Add support for WebSocket protocol negotiation ([#83](#83)) - Use `pin-project-lite` instead of `pin-project` ([#95](#95)) - Re-export `http` crate and `hyper::Server` ([#110](#110)) - Fix `Query` and `Form` extractors giving bad request error when query string is empty. ([#117](#117)) - Add `Path` extractor. ([#124](#124)) - Fixed the implementation of `IntoResponse` of `(HeaderMap, T)` and `(StatusCode, HeaderMap, T)` would ignore headers from `T` ([#137](#137)) - Deprecate `extract::UrlParams` and `extract::UrlParamsMap`. Use `extract::Path` instead ([#138](#138))
saad-aistack
added a commit
to saad-aistack/rust-high-perf-api
that referenced
this pull request
Mar 26, 2026
Since tokio-rs/axum#117 its no longer used. Will be removed in 0.2.
saad-aistack
added a commit
to saad-aistack/rust-high-perf-api
that referenced
this pull request
Mar 26, 2026
- Fix stripping prefix when nesting services at `/` ([#91](tokio-rs/axum#91)) - Add support for WebSocket protocol negotiation ([#83](tokio-rs/axum#83)) - Use `pin-project-lite` instead of `pin-project` ([#95](tokio-rs/axum#95)) - Re-export `http` crate and `hyper::Server` ([#110](tokio-rs/axum#110)) - Fix `Query` and `Form` extractors giving bad request error when query string is empty. ([#117](tokio-rs/axum#117)) - Add `Path` extractor. ([#124](tokio-rs/axum#124)) - Fixed the implementation of `IntoResponse` of `(HeaderMap, T)` and `(StatusCode, HeaderMap, T)` would ignore headers from `T` ([#137](tokio-rs/axum#137)) - Deprecate `extract::UrlParams` and `extract::UrlParamsMap`. Use `extract::Path` instead ([#138](tokio-rs/axum#138))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #82