Make Router faster to clone - #1123
Merged
Merged
Conversation
davidpdrsn
enabled auto-merge (squash)
June 26, 2022 21:05
jplatte
reviewed
Jun 27, 2022
Co-authored-by: Jonas Platte <jplatte+git@posteo.de>
jplatte
reviewed
Jun 27, 2022
Co-authored-by: Jonas Platte <jplatte+git@posteo.de>
jplatte
approved these changes
Jun 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Routeris cloned once for every request inIntoMakeService::callso ideally it should be cheap to do so.Solution
Wrap the
Nodein aArcand rebuild it when callingRouter::router. This is fine since it only happens during startup.I did a simple benchmark where I cloned a
Routerwith 1000 routes and this brought the time down from 176.916µs to 92.698µs. So almost 50% 📈I also attempted to
Arcthe other fields but since they're!SynctheArcbecomes!Sendwhich is a no-go. UsingSyncWrapperdoesn't help as that requires exclusive access which we cannot get through anArc.