Skip to content

Remove trailing slash redirects - #1119

Merged
davidpdrsn merged 18 commits into
mainfrom
remove-tsr
Jun 29, 2022
Merged

Remove trailing slash redirects#1119
davidpdrsn merged 18 commits into
mainfrom
remove-tsr

Conversation

@davidpdrsn

@davidpdrsn davidpdrsn commented Jun 25, 2022

Copy link
Copy Markdown
Member

Fixes #1118

@davidpdrsn davidpdrsn added breaking change A PR that makes a breaking change. A-axum labels Jun 25, 2022
@davidpdrsn
davidpdrsn requested a review from jplatte June 25, 2022 19:35
jplatte
jplatte reviewed Jun 27, 2022
View reviewed changes
Comment thread axum/CHANGELOG.md Outdated
Comment thread axum/src/routing/tests/mod.rs
@davidpdrsn davidpdrsn added this to the 0.6 milestone Jun 27, 2022
@davidpdrsn
Prepare axum-next branch
aa6557c
@davidpdrsn
Remove deprecated extractor_middleware function (#1077)
83ec57b
@davidpdrsn
Allow Error: Into<Infallible> for Route::{layer, route_layer} (#948)
6b33e46 
* Allow `Error: Into<Infallible>` for `Route::{layer, route_layer}` (#924)

* Allow `Error: Into<Infallible>` for `Route::{layer, route_layer}`

Fixes #922

* changelog

* fixup changelog
@davidpdrsn
Panic on overlapping routes in MethodRouter (#1102)
263f964 
* Panic on overlapping routes in `MethodRouter`

* changelog link

* add test to ensure `head` and `get` don't overlap
@davidpdrsn
Fix changelog
e53b8f7
@davidpdrsn
davidpdrsn requested a review from jplatte June 27, 2022 19:16
@davidpdrsn
davidpdrsn force-pushed the axum-next branch 2 times, most recently from f6dbabe to f6bab0f Compare June 28, 2022 19:35
Base automatically changed from axum-next to main June 28, 2022 20:07
@davidpdrsn
davidpdrsn enabled auto-merge (rebase) June 28, 2022 20:15
@davidpdrsn

davidpdrsn commented Jun 29, 2022

Copy link
Copy Markdown
Member Author

@jplatte I've added RouterExt::route_with_tsr. I figure we only need one method that can check whether the path from the user contains a trailing slash and then add the corresponding redirect route.

Re naming: The name isn't great but not sure route_with_trailing_slash_redirect is much better 😅

jplatte
jplatte reviewed Jun 29, 2022
View reviewed changes
Comment thread axum-extra/src/routing/mod.rs Outdated
Comment thread axum-extra/src/routing/mod.rs
Comment thread axum-extra/src/routing/mod.rs Outdated
Comment thread axum-extra/src/routing/mod.rs Outdated
davidpdrsn and others added 2 commits June 29, 2022 20:36
@davidpdrsn @jplatte
Apply suggestions from code review
aab3f76 
Co-authored-by: Jonas Platte <jplatte+git@posteo.de>
@davidpdrsn @jplatte
Update axum-extra/src/routing/mod.rs
c2d442a 
Co-authored-by: Jonas Platte <jplatte+git@posteo.de>
@davidpdrsn
davidpdrsn requested a review from jplatte June 29, 2022 18:37
jplatte
jplatte reviewed Jun 29, 2022
View reviewed changes
Comment thread axum/CHANGELOG.md Outdated
Comment thread axum/CHANGELOG.md Outdated
davidpdrsn and others added 2 commits June 29, 2022 23:12
@davidpdrsn
davidpdrsn requested a review from jplatte June 29, 2022 21:36
auto-merge was automatically disabled June 29, 2022 22:13

Rebase failed

@davidpdrsn
davidpdrsn merged commit a4c8204 into main Jun 29, 2022
@davidpdrsn
davidpdrsn deleted the remove-tsr branch June 29, 2022 22:22
@mladedav mladedav mentioned this pull request Mar 17, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@jplatte jplatte jplatte approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-axum breaking change A PR that makes a breaking change.

Projects

None yet

Milestone

0.6

Development

Successfully merging this pull request may close these issues.

Consider removing support for trailing slash redirects

2 participants

@davidpdrsn @jplatte