TMO_SHELL: DFU: Allow user entered file names #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows user entered file names for the pearl gecko boot slots and for the modem and wifi. Signed-off-by: Kim Mansfield <[email protected]>
There were 4 warnings that needed some coercion to remove them Signed-off-by: Kim Mansfield <[email protected]>
Some tweaks to get the user guides better and add slot to the mcu upload. Signed-off-by: Kim Mansfield <[email protected]>
Put in a couple of tweaks to the help messages to inform the user that slot numbers are mandatory. Signed-off-by: Kim Mansfield <[email protected]>
Signed-off-by: Kim Mansfield <[email protected]>
This is to prevent locking up the Pearl Gecko by programming a slot that the Pearl Gecko is running from. There are some checks in this push the prevents ths. Singed-off-by: Kim Mansfield <[email protected]>
Signed-off-by: Kim Mansfield <[email protected]>
loader Signed-off-by: Kim Mansfield <[email protected]>
slot Signed-off-by: Kim Mansfield <[email protected]>
johnlange2
reviewed
Nov 28, 2022
| switch(dfu_tgt) { | ||
| case DFU_GECKO: return "MCU"; | ||
| case DFU_MODEM: return "Modem"; | ||
| default: |
Contributor
There was a problem hiding this comment.
would prefer to use DFU_RS9116W here rather than defaulting to it. the default should return "error" or some such
This additional command (tmo dfu slot) will tell the user which slot he is running from or if not using a slot it will tell the user the BOOT_SLOT is undefined. Signed-off-by: Kim Mansfield <[email protected]>
Signed-off-by: Kim Mansfield <[email protected]>
Signed-off-by: Kim Mansfield <[email protected]>
johnlange2
reviewed
Nov 29, 2022
samples/tmo_shell/src/tmo_shell.c
Outdated
| } | ||
| } | ||
| #else | ||
| if (delta_firmware_target != 1) { |
Contributor
There was a problem hiding this comment.
i think this line should be removed so that it always returns an error when trying to update a slot without bootloader
Contributor
Author
There was a problem hiding this comment.
That is the way it use to work but Kevin had me add that line so that we could program if there is no slot being used.
Signed-off-by: Kim Mansfield <[email protected]>
Signed-off-by: Kim Mansfield <[email protected]>
johnlange2
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows user entered file names for the pearl gecko boot slots and for the modem and wifi.
Signed-off-by: Kim Mansfield [email protected]