Skip to content

Remove Unneeded Arguments #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 21, 2025
Merged

Remove Unneeded Arguments #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
274e69a
updated
robertgshaw2-redhat Apr 21, 2025
d273206
stash
robertgshaw2-redhat Apr 21, 2025
ce56622
cleanup
robertgshaw2-redhat Apr 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions vllm/distributed/kv_transfer/kv_connector/v1/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,8 +205,6 @@ def build_connector_meta(

Args:
scheduler_output (SchedulerOutput): the scheduler output object.
sending_KV_req_ids (set[str]): Request IDs to send
waiting_KV_req_ids (set[str]): Request IDs to receive
"""
pass

Expand Down
2 changes: 0 additions & 2 deletions vllm/v1/core/sched/output.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,4 @@ class SchedulerOutput:

# KV Cache Connector metadata.
kv_connector_metadata: Optional[KVConnectorMetadata] = None
sending_KV_req_ids: set[str] = field(default_factory=set)
receiving_KV_req_ids: set[str] = field(default_factory=set)
new_KV_req_ids_to_send: list[str] = field(default_factory=list)
5 changes: 1 addition & 4 deletions vllm/v1/core/sched/scheduler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,17 +506,14 @@ def schedule(self) -> SchedulerOutput:
free_encoder_input_ids=self.encoder_cache_manager.get_freed_ids(),
structured_output_request_ids=structured_output_request_ids,
grammar_bitmask=grammar_bitmask,
new_KV_req_ids_to_send=new_KV_req_ids_to_send,
)

# NOTE(Kuntai): this function is designed for multiple purposes:
# 1. Plan the KV cache store
# 2. Wrap up all the KV cache load / save ops into an opaque object
# 3. Clear the internal states of the connector
if self.connector is not None:
# TODO: encapsulate these in the KV connector metadata
scheduler_output.sending_KV_req_ids = self.sending_KV_req_ids
scheduler_output.new_KV_req_ids_to_send = new_KV_req_ids_to_send

meta = self.connector.build_connector_meta(scheduler_output)
scheduler_output.kv_connector_metadata = meta

Expand Down